Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove redis service to prevent more conflicts and add redis node to master_only #2354

Merged
merged 4 commits into from
Mar 3, 2022
Merged

fix: Remove redis service to prevent more conflicts and add redis node to master_only #2354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
22c9f6e
Fix redis on master.yml
kevjumba Mar 3, 2022
deb3e18
Remove hack in make_feature_store_yaml
kevjumba Mar 3, 2022
dfad434
Fix error
kevjumba Mar 3, 2022
84fef3c
Fix tests
kevjumba Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions .github/workflows/master_only.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,16 +65,6 @@ jobs:
env:
OS: ${{ matrix.os }}
PYTHON: ${{ matrix.python-version }}
services:
redis:
image: redis
ports:
- 6379:6379
options: >-
--health-cmd "redis-cli ping"
--health-interval 10s
--health-timeout 5s
--health-retries 5
steps:
- uses: actions/checkout@v2
- name: Setup Python
Expand Down Expand Up @@ -120,6 +110,11 @@ jobs:
run: pip install pip-tools
- name: Install dependencies
run: make install-python-ci-dependencies
- name: Start Redis
uses: supercharge/[email protected]
with:
redis-version: ${{ matrix.redis-version }}
redis-port: 12345
kevjumba marked this conversation as resolved.
Show resolved Hide resolved
- name: Setup Redis Cluster
run: |
docker pull vishnunair/docker-redis-cluster:latest
Expand Down
6 changes: 4 additions & 2 deletions sdk/python/tests/integration/registration/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,11 @@ def make_feature_store_yaml(project, test_repo_config, repo_dir_name: Path):
isinstance(config_dict["online_store"], dict)
and "redis_type" in config_dict["online_store"]
):
del config_dict["online_store"]["redis_type"]
if str(config_dict["online_store"]["redis_type"]) == "RedisType.redis_cluster":
config_dict["online_store"]["redis_type"] = "redis_cluster"
elif str(config_dict["online_store"]["redis_type"]) == "RedisType.redis":
config_dict["online_store"]["redis_type"] = "redis"
config_dict["repo_path"] = str(config_dict["repo_path"])

return yaml.safe_dump(config_dict)


Expand Down