-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Delete properties #2338
refactor: Delete properties #2338
Conversation
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
…KinesisSource, KinesisOptions Signed-off-by: Felix Wang <[email protected]>
…ce, SnowflakeSource Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2338 +/- ##
===========================================
- Coverage 86.33% 58.41% -27.93%
===========================================
Files 116 116
Lines 9886 9673 -213
===========================================
- Hits 8535 5650 -2885
- Misses 1351 4023 +2672
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Delete properties from FeatureService Signed-off-by: Felix Wang <[email protected]> * Delete properties from Entity Signed-off-by: Felix Wang <[email protected]> * Delete properties from BaseFeatureView Signed-off-by: Felix Wang <[email protected]> * Delete properties from DataSource Signed-off-by: Felix Wang <[email protected]> * Delete properties from RequestDataSource, KafkaSource, KafkaOptions, KinesisSource, KinesisOptions Signed-off-by: Felix Wang <[email protected]> * Delete unused properties for FileSource, BigQuerySource, RedshiftSource, SnowflakeSource Signed-off-by: Felix Wang <[email protected]> * Fix FileOptions error Signed-off-by: Felix Wang <[email protected]>
What this PR does / why we need it: This PR deletes unnecessary properties, and instead makes the attributes public.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: