Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podAnnotations Values in the feature-server chart #2304

Merged
merged 1 commit into from
Feb 13, 2022

Conversation

tpvasconcelos
Copy link
Contributor

@tpvasconcelos tpvasconcelos commented Feb 11, 2022

What this PR does / why we need it:

This PR adds the possibility of a user passing arbitrary podAnnotations Values to the feature-server chart.

Reference: https://tectonfeast.slack.com/archives/C01MSKCMB37/p1644600405847739

@feast-ci-bot
Copy link
Collaborator

@tpvasconcelos: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]>
@tpvasconcelos tpvasconcelos marked this pull request as ready for review February 12, 2022 15:14
@tpvasconcelos tpvasconcelos requested a review from a team as a code owner February 12, 2022 15:14
@tpvasconcelos tpvasconcelos requested review from adchia and removed request for a team February 12, 2022 15:14
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, tpvasconcelos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2022

Codecov Report

Merging #2304 (70a0105) into master (144f25c) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2304      +/-   ##
==========================================
- Coverage   86.15%   86.06%   -0.09%     
==========================================
  Files         116      116              
  Lines        9820     9820              
==========================================
- Hits         8460     8452       -8     
- Misses       1360     1368       +8     
Flag Coverage Δ
integrationtests 74.78% <ø> (-0.37%) ⬇️
unittests 58.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/wait.py 58.82% <0.00%> (-35.30%) ⬇️
.../integration/online_store/test_universal_online.py 97.17% <0.00%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 144f25c...70a0105. Read the comment docs.

@feast-ci-bot feast-ci-bot merged commit e02e91d into feast-dev:master Feb 13, 2022
adchia pushed a commit that referenced this pull request Feb 15, 2022
aht added a commit to aht/feast that referenced this pull request Feb 23, 2022
…ents

* upstream/master: (103 commits)
  refactor: Move create cluster script
  ci: Add validation for upper case PR titles
  Switch order of views to keep/delete to fix apply logging
  ci: Fix broken Prow plugin which ignores config.yaml
  ci: Add PR linting to ensure conventional commits are followed for PR titles
  Add owner field to FeatureService (feast-dev#2321)
  Disable Redis cluster tests (feast-dev#2327)
  Use PR title for commit message
  Add redis cluster initialziation to master github workflow (feast-dev#2317)
  Fix materialize bug with RedisCluster (feast-dev#2311)
  Add support for Dask during historical retrieval (feast-dev#1954)
  downgrade datatypes to 8
  Update pom.xml to 0.18.2 SNAPSHOT
  Update changelog for 0.18.1 and update pom.xml
  Update helm chart version
  Don't require `snowflake` to always be installed (feast-dev#2309)
  Fixing the Java helm charts and adding a demo tutorial on how to use them (feast-dev#2298)
  Include infra objects in registry dump and fix Infra's from_proto  (feast-dev#2295)
  Remove old flag warning with the python feature server (feast-dev#2300)
  podAnnotations Values in the feature-server chart (feast-dev#2304)
  ...
@tpvasconcelos tpvasconcelos deleted the podAnnotations branch October 7, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants