-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid using transactions on OSS Redis #2296
avoid using transactions on OSS Redis #2296
Conversation
Signed-off-by: DvirDukhan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2296 +/- ##
==========================================
+ Coverage 86.01% 86.06% +0.05%
==========================================
Files 116 116
Lines 9820 9820
==========================================
+ Hits 8447 8452 +5
+ Misses 1373 1368 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, DvirDukhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: DvirDukhan <[email protected]>
Signed-off-by: DvirDukhan [email protected]
What this PR does / why we need it:
This PR avoids using Transactions in redis-py pipelines when on a single instance mode.
redis-py pipelines are created by default as transactions https://github.com/redis/redis-py/blob/24cdd70761c7c275d5010f628f83d919bf35fc90/redis/client.py#L1020
However, on cluster mode, redis-py pipeline is built with
transaction=None
https://github.com/redis/redis-py/blob/045d5ed15305ccc44a0330e6f65f669998815598/redis/cluster.py#L698from https://redis.io/topics/transactions :
This could change can help increasing throughput when accessing a single Redis instance with multiple Feast clients.
Does this PR introduce a user-facing change?:
CC @chayim