Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an OFFLINE schema for Snowflake offline store tests #2291

Merged

Conversation

sfc-gh-madkins
Copy link
Collaborator

Signed-off-by: sfc-gh-madkins [email protected]

What this PR does / why we need it:

Aligns our snowflake testing code with the snowflake testing environment

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: sfc-gh-madkins <[email protected]>
@sfc-gh-madkins sfc-gh-madkins requested a review from a team as a code owner February 6, 2022 19:08
@sfc-gh-madkins sfc-gh-madkins requested review from pyalex and removed request for a team February 6, 2022 19:08
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2022

Codecov Report

Merging #2291 (4167615) into master (023dc36) will decrease coverage by 27.59%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2291       +/-   ##
===========================================
- Coverage   86.15%   58.55%   -27.60%     
===========================================
  Files         116      116               
  Lines        9820     9820               
===========================================
- Hits         8460     5750     -2710     
- Misses       1360     4070     +2710     
Flag Coverage Δ
integrationtests ?
unittests 58.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../feature_repos/universal/data_sources/snowflake.py 51.35% <ø> (-48.65%) ⬇️
.../integration/online_store/test_universal_online.py 15.32% <0.00%> (-82.67%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 20.68% <0.00%> (-79.32%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.50% <0.00%> (-76.50%) ⬇️
sdk/python/feast/wait.py 23.52% <0.00%> (-70.59%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 26.45% <0.00%> (-68.39%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) ⬇️
sdk/python/feast/infra/utils/snowflake_utils.py 23.36% <0.00%> (-65.43%) ⬇️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 023dc36...4167615. Read the comment docs.

@adchia adchia changed the title fixed snowflake testing env Use an OFFLINE schema for Snowflake offline store tests Feb 6, 2022
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, sfc-gh-madkins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 925bf76 into feast-dev:master Feb 6, 2022
@sfc-gh-madkins sfc-gh-madkins deleted the update_snowflake_offline_tests branch February 26, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants