-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky tests (test_online_store_cleanup & test_feature_get_online_features_types_match) #2276
Conversation
Signed-off-by: pyalex <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2276 +/- ##
===========================================
+ Coverage 58.60% 86.06% +27.46%
===========================================
Files 116 116
Lines 9810 9820 +10
===========================================
+ Hits 5749 8452 +2703
+ Misses 4061 1368 -2693
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: pyalex <[email protected]>
Signed-off-by: pyalex <[email protected]>
Signed-off-by: pyalex <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
fs.materialize( | ||
environment.start_date, | ||
environment.end_date | ||
- timedelta(hours=1) # throwing out last record to make sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non blocking, but kind of confusing why this ensures we infer from all empty values
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: pyalex [email protected]
What this PR does / why we need it:
Several issues addressed in this PR:
test_online_store_cleanup
some online stores (like dynamo) can have eventual consistency of schema. So when table was deleted it might need some time before it can be recreated.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: