Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / update helm chart workflows to push the feast python server #2273

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Feb 3, 2022

What this PR does / why we need it:
The existing script does not successfully run for a variety of reasons. Also, it does not package and push the python feature server. This fixes those (though requires we remove old versions of the helm chart for the java feature server due to weird versioning issues)

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

…lso fixing broken publishing flow and updating versions

Signed-off-by: Danny Chiao <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #2273 (370ae8f) into master (6e30457) will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2273      +/-   ##
==========================================
+ Coverage   85.82%   86.02%   +0.20%     
==========================================
  Files         116      116              
  Lines        9790     9809      +19     
==========================================
+ Hits         8402     8438      +36     
+ Misses       1388     1371      -17     
Flag Coverage Δ
integrationtests 74.81% <ø> (-0.09%) ⬇️
unittests 58.59% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/on_demand_feature_view.py 95.33% <0.00%> (+0.12%) ⬆️
sdk/python/feast/registry.py 85.17% <0.00%> (+0.67%) ⬆️
sdk/python/feast/base_feature_view.py 78.94% <0.00%> (+0.68%) ⬆️
sdk/python/feast/feature_view.py 92.02% <0.00%> (+1.24%) ⬆️
sdk/python/feast/saved_dataset.py 82.45% <0.00%> (+1.75%) ⬆️
sdk/python/feast/infra/online_stores/datastore.py 90.56% <0.00%> (+1.88%) ⬆️
sdk/python/feast/feature_service.py 86.27% <0.00%> (+3.92%) ⬆️
sdk/python/feast/entity.py 78.40% <0.00%> (+4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e30457...370ae8f. Read the comment docs.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit fc37896 into feast-dev:master Feb 3, 2022
@adchia adchia deleted the pythonPush branch March 4, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants