Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Feast Serving documentation with ways to run and debug locally #2272

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Feb 2, 2022

What this PR does / why we need it:
Removes old documentation for Feast Serving and adds new instructions for debugging locally

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@adchia adchia requested a review from a team as a code owner February 2, 2022 23:58
@adchia adchia requested review from mavysavydav and removed request for a team February 2, 2022 23:58
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #2272 (39660fa) into master (6e30457) will decrease coverage by 27.22%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2272       +/-   ##
===========================================
- Coverage   85.82%   58.59%   -27.23%     
===========================================
  Files         116      116               
  Lines        9790     9809       +19     
===========================================
- Hits         8402     5748     -2654     
- Misses       1388     4061     +2673     
Flag Coverage Δ
integrationtests ?
unittests 58.59% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_universal_online.py 15.00% <0.00%> (-82.92%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 20.68% <0.00%> (-79.32%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.50% <0.00%> (-76.50%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 26.45% <0.00%> (-68.39%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) ⬇️
sdk/python/feast/infra/utils/snowflake_utils.py 23.36% <0.00%> (-65.43%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 35.18% <0.00%> (-64.82%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e30457...39660fa. Read the comment docs.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit bb676f2 into feast-dev:master Feb 3, 2022
@adchia adchia deleted the updateFeastServingDocs branch March 4, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants