-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use datetime.utcnow()
to avoid timezone issues
#2265
Conversation
Signed-off-by: Judah Rand <[email protected]>
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #2265 +/- ##
==========================================
+ Coverage 85.27% 85.42% +0.15%
==========================================
Files 108 112 +4
Lines 9127 9593 +466
==========================================
+ Hits 7783 8195 +412
- Misses 1344 1398 +54
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, judahrand, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Judah Rand [email protected]
What this PR does / why we need it:
Use
datetime.now
has the potential for timezone issues, especially when persisting the data to the Registry.Which issue(s) this PR fixes:
Use
datetime.utcnow
instead.Fixes #
Does this PR introduce a user-facing change?: