Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate Python feature server #2263

Merged
merged 6 commits into from
Feb 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions docs/SUMMARY.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@
## How-to Guides

* [Running Feast with Snowflake/GCP/AWS](how-to-guides/feast-snowflake-gcp-aws/README.md)
* [Install Feast](how-to-guides/feast-gcp-aws/install-feast.md)
* [Create a feature repository](how-to-guides/feast-gcp-aws/create-a-feature-repository.md)
* [Deploy a feature store](how-to-guides/feast-gcp-aws/deploy-a-feature-store.md)
* [Build a training dataset](how-to-guides/feast-gcp-aws/build-a-training-dataset.md)
* [Load data into the online store](how-to-guides/feast-gcp-aws/load-data-into-the-online-store.md)
* [Read features from the online store](how-to-guides/feast-gcp-aws/read-features-from-the-online-store.md)
* [Install Feast](how-to-guides/feast-snowflake-gcp-aws/install-feast.md)
* [Create a feature repository](how-to-guides/feast-snowflake-gcp-aws/create-a-feature-repository.md)
* [Deploy a feature store](how-to-guides/feast-snowflake-gcp-aws/deploy-a-feature-store.md)
* [Build a training dataset](how-to-guides/feast-snowflake-gcp-aws/build-a-training-dataset.md)
* [Load data into the online store](how-to-guides/feast-snowflake-gcp-aws/load-data-into-the-online-store.md)
* [Read features from the online store](how-to-guides/feast-snowflake-gcp-aws/read-features-from-the-online-store.md)
* [Running Feast in production](how-to-guides/running-feast-in-production.md)
* [Upgrading from Feast 0.9](https://docs.google.com/document/u/1/d/1AOsr\_baczuARjCpmZgVd8mCqTF4AZ49OEyU4Cn-uTT0/edit)
* [Adding a custom provider](how-to-guides/creating-a-custom-provider.md)
Expand Down Expand Up @@ -75,9 +75,10 @@
* [Feature repository](reference/feature-repository/README.md)
* [feature\_store.yaml](reference/feature-repository/feature-store-yaml.md)
* [.feastignore](reference/feature-repository/feast-ignore.md)
* [Feature servers](reference/feature-servers/README.md)
* [Local feature server](reference/feature-servers/local-feature-server.md)
* [\[Alpha\] On demand feature view](reference/alpha-on-demand-feature-view.md)
* [\[Alpha\] Stream ingestion](reference/alpha-stream-ingestion.md)
* [\[Alpha\] Local feature server](reference/feature-server.md)
* [\[Alpha\] AWS Lambda feature server](reference/alpha-aws-lambda-feature-server.md)
* [Feast CLI reference](reference/feast-cli-commands.md)
* [Python API reference](http://rtd.feast.dev)
Expand Down
2 changes: 0 additions & 2 deletions docs/architecture.md

This file was deleted.

2 changes: 0 additions & 2 deletions docs/build-a-training-dataset.md

This file was deleted.

2 changes: 0 additions & 2 deletions docs/create-a-feature-repository.md

This file was deleted.

2 changes: 0 additions & 2 deletions docs/deploy-a-feature-store.md

This file was deleted.

2 changes: 0 additions & 2 deletions docs/entities.md

This file was deleted.

2 changes: 0 additions & 2 deletions docs/feature-views.md

This file was deleted.

2 changes: 0 additions & 2 deletions docs/load-data-into-the-online-store.md

This file was deleted.

2 changes: 0 additions & 2 deletions docs/read-features-from-the-online-store.md

This file was deleted.

5 changes: 5 additions & 0 deletions docs/reference/feature-servers/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Feature servers

Feast users can choose to retrieve features from a feature server, as opposed to through the Python SDK.

{% page-ref page="local-feature-server.md" %}
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
# \[Alpha\] Local feature server

**Warning**: This is an _experimental_ feature. It's intended for early testing and feedback, and could change without warnings in future releases.

{% hint style="info" %}
To enable this feature, run **`feast alpha enable python_feature_server`**
{% endhint %}
# Local feature server

## Overview

Expand Down Expand Up @@ -122,4 +116,3 @@ curl -X POST \
}
}' | jq
```

2 changes: 0 additions & 2 deletions docs/reference/repository-config.md

This file was deleted.

12 changes: 0 additions & 12 deletions docs/reference/telemetry.md

This file was deleted.

2 changes: 0 additions & 2 deletions docs/repository-config.md

This file was deleted.

2 changes: 0 additions & 2 deletions docs/sources.md

This file was deleted.

12 changes: 0 additions & 12 deletions infra/charts/feast-python-server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,4 @@ RUN pip install pip --upgrade
RUN pip install feast

COPY feature_store.yaml /feature_store.yaml
```

Make sure that you have enabled the flags for the python server. Example `feature_store.yaml`:
```
project: feature_repo
registry: data/registry.db
provider: local
online_store:
path: data/online_store.db
flags:
alpha_features: true
python_feature_server: true
```
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@ provider: local
project: {{ .Values.global.project }}
flags:
on_demand_transforms: true
python_feature_server: true
alpha_features: true
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,3 @@ offline_store: {}
flags:
alpha_features: true
on_demand_transforms: true
python_feature_server: true
5 changes: 0 additions & 5 deletions sdk/python/feast/feature_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -1769,9 +1769,6 @@ def _get_feature_views_to_use(
@log_exceptions_and_usage
def serve(self, host: str, port: int, no_access_log: bool) -> None:
"""Start the feature consumption server locally on a given port."""
if not flags_helper.enable_python_feature_server(self.config):
raise ExperimentalFeatureNotEnabled(flags.FLAG_PYTHON_FEATURE_SERVER_NAME)

feature_server.start_server(self, host, port, no_access_log)

@log_exceptions_and_usage
Expand All @@ -1782,8 +1779,6 @@ def get_feature_server_endpoint(self) -> Optional[str]:
@log_exceptions_and_usage
def serve_transformations(self, port: int) -> None:
"""Start the feature transformation server locally on a given port."""
if not flags_helper.enable_python_feature_server(self.config):
raise ExperimentalFeatureNotEnabled(flags.FLAG_PYTHON_FEATURE_SERVER_NAME)
if not flags_helper.enable_on_demand_feature_views(self.config):
raise ExperimentalFeatureNotEnabled(flags.FLAG_ON_DEMAND_TRANSFORM_NAME)

Expand Down
2 changes: 0 additions & 2 deletions sdk/python/feast/flags.py
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
FLAG_ALPHA_FEATURES_NAME = "alpha_features"
FLAG_ON_DEMAND_TRANSFORM_NAME = "on_demand_transforms"
FLAG_PYTHON_FEATURE_SERVER_NAME = "python_feature_server"
FLAG_AWS_LAMBDA_FEATURE_SERVER_NAME = "aws_lambda_feature_server"
FLAG_DIRECT_INGEST_TO_ONLINE_STORE = "direct_ingest_to_online_store"
ENV_FLAG_IS_TEST = "IS_TEST"

FLAG_NAMES = {
FLAG_ALPHA_FEATURES_NAME,
FLAG_ON_DEMAND_TRANSFORM_NAME,
FLAG_PYTHON_FEATURE_SERVER_NAME,
FLAG_AWS_LAMBDA_FEATURE_SERVER_NAME,
FLAG_DIRECT_INGEST_TO_ONLINE_STORE,
}
4 changes: 0 additions & 4 deletions sdk/python/feast/flags_helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ def enable_on_demand_feature_views(repo_config: RepoConfig) -> bool:
return feature_flag_enabled(repo_config, flags.FLAG_ON_DEMAND_TRANSFORM_NAME)


def enable_python_feature_server(repo_config: RepoConfig) -> bool:
return feature_flag_enabled(repo_config, flags.FLAG_PYTHON_FEATURE_SERVER_NAME)


def enable_aws_lambda_feature_server(repo_config: RepoConfig) -> bool:
return feature_flag_enabled(repo_config, flags.FLAG_AWS_LAMBDA_FEATURE_SERVER_NAME)

Expand Down