Historical field mappings #2251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michelle Rascati <[email protected]>
Signed-off-by: Michelle Rascati <[email protected]>
… return field mapped names Signed-off-by: Michelle Rascati <[email protected]>
Signed-off-by: Michelle Rascati <[email protected]>
Signed-off-by: Michelle Rascati <[email protected]>
…ling happy" This reverts commit af8fc85.
michelle-rascati-sp
requested review from
adchia
and removed request for
a team
sdk/python/feast/feature_store.py
Outdated
| @@ -1437,7 +1438,7 @@ def _read_from_online_store( | |||
| provider: Provider, | |||
| requested_features: List[str], | |||
| table: FeatureView, | |||
| ) -> List[Tuple[List[Timestamp], List["FieldStatus.ValueType"], List[Value]]]: | |||
| ) -> List[Tuple[List[Timestamp], List[FieldStatusValue], List[Value]]]: | |||
There was a problem hiding this comment.
Trying to resolve #2249 but I can revert.
…dStatusValue" This reverts commit 60e3692.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: michelle-rascati-sp The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Closing for sign-off issues, see: #2252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Uses field mapping to convert feature names into column names, and back to feature names for Redshift and DyanmoDB data sources when calling
get_historical_features()Which issue(s) this PR fixes:
Fixes #2248
Does this PR introduce a user-facing change?: