Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor pa_to_feast_value_type #2246

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Refactor pa_to_feast_value_type #2246

merged 2 commits into from
Feb 1, 2022

Conversation

judahrand
Copy link
Member

@judahrand judahrand commented Jan 27, 2022 •
edited
Loading

What this PR does / why we need it:

This refactoring is intented to make it more difficult
to forget to add conversion for LIST versions of
non-LIST types.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

None

@judahrand judahrand requested a review from a team as a code owner January 27, 2022 11:42
@judahrand judahrand requested review from mavysavydav and removed request for a team January 27, 2022 11:42
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022 •
edited
Loading

Codecov Report

Merging #2246 (5c342e5) into master (53539cf) will increase coverage by 0.01%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2246      +/-   ##
==========================================
+ Coverage   85.42%   85.43%   +0.01%     
==========================================
  Files         112      112              
  Lines        9573     9581       +8     
==========================================
+ Hits         8178     8186       +8     
  Misses       1395     1395
Flag Coverage Δ
integrationtests 73.95% <82.35%> (-0.31%) ⬇️
unittests 58.67% <47.05%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/type_map.py 69.67% <72.72%> (-0.80%) ⬇️
...s/integration/registration/test_universal_types.py 98.76% <100.00%> (+0.01%) ⬆️
.../integration/online_store/test_universal_online.py 97.50% <0.00%> (-0.42%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 90.56% <0.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53539cf...5c342e5. Read the comment docs.

felixwang9817
felixwang9817 approved these changes Jan 30, 2022
View reviewed changes
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@judahrand judahrand force-pushed the pyarrow-to-valuetype branch from d190b11 to 639fd4d Compare February 1, 2022 15:55
@feast-ci-bot feast-ci-bot removed the lgtm label Feb 1, 2022
@judahrand
Refactor pa_to_feast_value_type
65cfa84 
This refactoring is intented to make it more difficult
to forget to add conversion for LIST versions of
non-LIST types.

Signed-off-by: Judah Rand <[email protected]>
@judahrand
Tidy up assert_expected_arrow_types
5c342e5 
Signed-off-by: Judah Rand <[email protected]>
@judahrand judahrand force-pushed the pyarrow-to-valuetype branch from 639fd4d to 5c342e5 Compare February 1, 2022 15:59
@feast-dev feast-dev deleted a comment from feast-ci-bot Feb 1, 2022
felixwang9817
felixwang9817 approved these changes Feb 1, 2022
View reviewed changes
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, judahrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 2080fa3 into feast-dev:master Feb 1, 2022
@judahrand judahrand deleted the pyarrow-to-valuetype branch February 1, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixwang9817 felixwang9817 felixwang9817 approved these changes

@mavysavydav mavysavydav Awaiting requested review from mavysavydav mavysavydav was automatically assigned from feast-dev/maintainers

Assignees

@achals achals

@felixwang9817 felixwang9817

Labels
approved kind/housekeeping lgtm ok-to-test release-note-none size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@judahrand @codecov-commenter @feast-ci-bot @felixwang9817 @achals