-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using pandas.StringDtype to support on-demand features with STRING type #2229
Conversation
Signed-off-by: pyalex <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2229 +/- ##
===========================================
- Coverage 84.94% 59.88% -25.07%
===========================================
Files 105 105
Lines 8496 8512 +16
===========================================
- Hits 7217 5097 -2120
- Misses 1279 3415 +2136
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: pyalex [email protected]
What this PR does / why we need it:
Currently it's impossible to create on demand feature view with feature of type string since type inference doesn't support
pandas.StringDtype
and dtypeobject
. This PR adds support forpandas.StringDtype
. Now string feature can be defined as following:Also during inference, we now raise ValueError with some details instead of AssertionError, which was confusing.
Which issue(s) this PR fixes:
Fixes #2220
Does this PR introduce a user-facing change?: