Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python FeatureServer optimization #2202

Merged
merged 5 commits into from
Jan 18, 2022

Conversation

judahrand
Copy link
Member

@judahrand judahrand commented Jan 7, 2022

What this PR does / why we need it:
Previously, the Python FeatureServer was doing pointless conversion of Protobuf entity values to Python native types only to convert them back again.

This PR is stacked on top of #2186 so only the last commit is relevant to the issue.

Which issue(s) this PR fixes:

Fixes #2201

Does this PR introduce a user-facing change?:

None

@judahrand judahrand requested a review from a team as a code owner January 7, 2022 12:38
@judahrand judahrand requested review from felixwang9817 and removed request for a team January 7, 2022 12:38
@judahrand judahrand changed the title Feature server opt Python FeatureServer optimization Jan 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #2202 (65dea14) into master (1b98ec9) will increase coverage by 25.12%.
The diff coverage is 78.08%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2202       +/-   ##
===========================================
+ Coverage   59.83%   84.96%   +25.12%     
===========================================
  Files         105      105               
  Lines        8453     8493       +40     
===========================================
+ Hits         5058     7216     +2158     
+ Misses       3395     1277     -2118     
Flag Coverage Δ
integrationtests 73.12% <78.08%> (?)
unittests 59.73% <73.97%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_server.py 31.57% <0.00%> (+0.80%) ⬆️
sdk/python/feast/feature_store.py 90.13% <80.28%> (+17.31%) ⬆️
sdk/python/feast/data_source.py 61.29% <0.00%> (+0.40%) ⬆️
sdk/python/feast/infra/online_stores/sqlite.py 94.48% <0.00%> (+0.78%) ⬆️
sdk/python/feast/online_response.py 77.77% <0.00%> (+3.70%) ⬆️
sdk/python/feast/feature.py 90.24% <0.00%> (+4.87%) ⬆️
sdk/python/feast/errors.py 71.01% <0.00%> (+5.07%) ⬆️
sdk/python/feast/infra/provider.py 89.65% <0.00%> (+5.17%) ⬆️
sdk/python/feast/infra/offline_stores/file.py 97.60% <0.00%> (+8.79%) ⬆️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b98ec9...65dea14. Read the comment docs.

@judahrand judahrand force-pushed the feature-server-opt branch 2 times, most recently from ea7639b to f7dcc0d Compare January 7, 2022 16:32
@judahrand judahrand force-pushed the feature-server-opt branch 2 times, most recently from 9b06bce to 5882165 Compare January 7, 2022 18:30
@achals
Copy link
Member

achals commented Jan 7, 2022

@judahrand is this ready for review? Now that #2186 has been merged.

@judahrand
Copy link
Member Author

judahrand commented Jan 7, 2022

@judahrand is this ready for review? Now that #2186 has been merged.

I'm struggling to work out why the FeatureServer tests are failing and don't have a good way to debug since the FeatureServer is only supported by the AWS test 🤔

@judahrand judahrand force-pushed the feature-server-opt branch 2 times, most recently from 940d755 to 5e6f979 Compare January 7, 2022 21:28
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Show resolved Hide resolved
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
Signed-off-by: Judah Rand <[email protected]>
@judahrand judahrand requested a review from adchia January 18, 2022 16:06
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, judahrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 05f4e8f into feast-dev:master Jan 18, 2022
@judahrand judahrand deleted the feature-server-opt branch January 19, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python FeatureServer inefficiently converts entity rows
6 participants