-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python FeatureServer optimization #2202
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2202 +/- ##
===========================================
+ Coverage 59.83% 84.96% +25.12%
===========================================
Files 105 105
Lines 8453 8493 +40
===========================================
+ Hits 5058 7216 +2158
+ Misses 3395 1277 -2118
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ea7639b
to
f7dcc0d
Compare
9b06bce
to
5882165
Compare
@judahrand is this ready for review? Now that #2186 has been merged. |
I'm struggling to work out why the FeatureServer tests are failing and don't have a good way to debug since the FeatureServer is only supported by the AWS test 🤔 |
940d755
to
5e6f979
Compare
Signed-off-by: Judah Rand <[email protected]>
5e6f979
to
179f272
Compare
Signed-off-by: Judah Rand <[email protected]>
Signed-off-by: Judah Rand <[email protected]>
Signed-off-by: Judah Rand <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, judahrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Previously, the Python FeatureServer was doing pointless conversion of Protobuf entity values to Python native types only to convert them back again.
This PR is stacked on top of #2186 so only the last commit is relevant to the issue.
Which issue(s) this PR fixes:
Fixes #2201
Does this PR introduce a user-facing change?: