Refactor all importer logic to belong in feast.importer

[felixwang9817]

Signed-off-by: Felix Wang [email protected]

What this PR does / why we need it: This PR takes all importer logic and refactors it so that all importer logic belongs to a single method, get_class_from_module, in feast.importer.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

[codecov-commenter]

Codecov Report

Merging #2199 (1edcc37) into master (14048fd) will decrease coverage by 0.17%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #2199      +/-   ##
==========================================
- Coverage   84.63%   84.45%   -0.18%     
==========================================
  Files         104      104              
  Lines        8272     8247      -25     
==========================================
- Hits         7001     6965      -36     
- Misses       1271     1282      +11     

Flag	Coverage Δ
integrationtests	74.20% <83.33%> (-0.48%)	⬇️
unittests	58.65% <80.00%> (-0.31%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../python/tests/integration/registration/test_cli.py	100.00% <ø> (ø)
sdk/python/feast/importer.py	64.28% <50.00%> (ø)
sdk/python/feast/infra/infra_object.py	57.50% <50.00%> (ø)
sdk/python/feast/errors.py	71.11% <75.00%> (ø)
...python/feast/infra/offline_stores/offline_utils.py	95.74% <100.00%> (+3.66%)	⬆️
sdk/python/feast/infra/online_stores/helpers.py	100.00% <100.00%> (+12.90%)	⬆️
sdk/python/feast/infra/provider.py	90.17% <100.00%> (+0.08%)	⬆️
sdk/python/feast/registry.py	83.60% <100.00%> (-1.68%)	⬇️
sdk/python/feast/repo_config.py	87.00% <100.00%> (ø)
sdk/python/feast/type_map.py	60.93% <0.00%> (-11.72%)	⬇️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14048fd...1edcc37. Read the comment docs.

[pyalex]

alternatively, we can make class_type something like base class expectations, eg we import class FileStorage and expect that it's a subtype of Storage.

Check base classes of imported type instead of naming could look like this

if not any(base_class.__name__ in class_type for base_class _class.__bases__):
    raise 

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pyalex]

/lgtm