Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 203]: fix the datetime column format during the import via python sdk #217

Merged

Conversation

romanwozniak
Copy link
Collaborator

@romanwozniak romanwozniak commented Jun 17, 2019

To fix: #203

  • Replace the custom datetime format pattern with a generic .isoformat() function call

@feast-ci-bot
Copy link
Collaborator

Hi @romanwozniak. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@romanwozniak
Copy link
Collaborator Author

/ok-to-test

@romanwozniak
Copy link
Collaborator Author

/retest

@romanwozniak
Copy link
Collaborator Author

/assign @zhilingc
/assign @davidheryanto
/assign @budi

@davidheryanto
Copy link
Collaborator

/lgtm

@pradithya
Copy link
Collaborator

/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradithya, romanwozniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pradithya,romanwozniak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 8d02aaf into feast-dev:master Jun 18, 2019
@romanwozniak romanwozniak deleted the feast_203_datetime_format_issue branch June 18, 2019 06:07
@woop woop unassigned budi May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch Import, feature with datetime format issue
6 participants