Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin boto dependency in setup #2168

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

fengyu05
Copy link
Contributor

@fengyu05 fengyu05 commented Dec 22, 2021

What this PR does / why we need it:

The feast[aws] pin boto3 to 1.17.* which create forward compatibles issue.
Removing the pin to undo the issue.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Unpin dependency on boto3

@fengyu05 fengyu05 requested a review from a team as a code owner December 22, 2021 22:38
@fengyu05 fengyu05 requested review from mavysavydav and removed request for a team December 22, 2021 22:38
@feast-ci-bot
Copy link
Collaborator

Hi @fengyu05. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@delete-merged-branch delete-merged-branch bot deleted the zf/unpin-boto branch December 22, 2021 23:01
@achals
Copy link
Member

achals commented Dec 23, 2021

/ok-to-test

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #2168 (aa3245c) into master (b8daefa) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2168      +/-   ##
==========================================
- Coverage   84.58%   84.57%   -0.02%     
==========================================
  Files         102      102              
  Lines        8175     8175              
==========================================
- Hits         6915     6914       -1     
- Misses       1260     1261       +1     
Flag Coverage Δ
integrationtests 74.32% <ø> (-0.30%) ⬇️
unittests 58.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_universal_online.py 97.67% <0.00%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8daefa...aa3245c. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, fengyu05

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit a8ad523 into feast-dev:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants