Improve serialization performance #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2165 +/- ##
==========================================
- Coverage 84.57% 84.56% -0.01%
==========================================
Files 102 102
Lines 8173 8175 +2
==========================================
+ Hits 6912 6913 +1
- Misses 1261 1262 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Judah Rand <[email protected]>
judahrand
force-pushed
the
perf-serialize
branch
from
c20a5b5 to
9382202
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, judahrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Judah Rand [email protected]
What this PR does / why we need it:
Similar quick pass as the deserialize PR (#2164). A definite improvement but not as drastic as the other one. Looks like between 20-30% improvement. This is achieved by avoiding memory copies as much as possible by using Numpy and allowing Protobuf to handle that more sensibly than copying to convert to Python object then copying back again to create Protobuf Message.
Same benchmark as the deserialize PR:
On
master:With changes:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: