Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a unit test for the tag_proto_objects method #2163

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

achals
Copy link
Member

@achals achals commented Dec 20, 2021

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:
This PR just adds tests for a fairly critical piece of code.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

none

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #2163 (062eb4a) into master (a710cb9) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2163      +/-   ##
==========================================
+ Coverage   84.39%   84.45%   +0.05%     
==========================================
  Files         101      102       +1     
  Lines        8133     8163      +30     
==========================================
+ Hits         6864     6894      +30     
  Misses       1269     1269              
Flag Coverage Δ
integrationtests 74.18% <16.66%> (-0.51%) ⬇️
unittests 58.88% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/unit/diff/test_fco_diff.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a710cb9...062eb4a. Read the comment docs.

Signed-off-by: Achal Shah <[email protected]>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, tsotnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants