Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BYTES and BYTES_LIST type conversion #2158

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

judahrand
Copy link
Member

@judahrand judahrand commented Dec 17, 2021

Signed-off-by: Judah Rand 17158624+judahrand@users.noreply.github.com

What this PR does / why we need it:
Currently, any get_online_features which tries to retrieve a ValueType.BYTES Feature will fail due to an incorrect conversion.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Fix BYTES and BYTES_LIST type conversion

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2158 (25ec81b) into master (90b8426) will decrease coverage by 0.17%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2158      +/-   ##
==========================================
- Coverage   84.60%   84.43%   -0.18%     
==========================================
  Files         101      101              
  Lines        7968     8099     +131     
==========================================
+ Hits         6741     6838      +97     
- Misses       1227     1261      +34     
Flag Coverage Δ
integrationtests 74.39% <33.33%> (-0.49%) ⬇️
unittests 58.80% <33.33%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/type_map.py 72.53% <33.33%> (+0.19%) ⬆️
sdk/python/feast/infra/online_stores/datastore.py 80.11% <0.00%> (-11.23%) ⬇️
sdk/python/feast/registry_store.py 68.42% <0.00%> (-6.58%) ⬇️
sdk/python/tests/doctest/test_all.py 89.65% <0.00%> (-3.08%) ⬇️
sdk/python/feast/repo_operations.py 48.37% <0.00%> (-1.87%) ⬇️
sdk/python/feast/infra/online_stores/dynamodb.py 80.45% <0.00%> (-1.23%) ⬇️
sdk/python/feast/cli.py 38.34% <0.00%> (-0.07%) ⬇️
sdk/python/feast/feature_store.py 91.37% <0.00%> (+0.50%) ⬆️
sdk/python/feast/entity.py 74.40% <0.00%> (+0.80%) ⬆️
sdk/python/feast/registry.py 87.24% <0.00%> (+0.91%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90b8426...25ec81b. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, judahrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 5ce0fdb into feast-dev:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants