Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SqliteTable as an InfraObject #2157

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: This PR adds SQLite as an InfraObject, as part of the feast plan implementation.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817 felixwang9817 requested a review from a team as a code owner December 17, 2021 01:49
@felixwang9817 felixwang9817 requested review from tsotnet and removed request for a team December 17, 2021 01:49
@felixwang9817 felixwang9817 requested review from achals and removed request for tsotnet December 17, 2021 01:49
@felixwang9817 felixwang9817 added the kind/feature New feature or request label Dec 17, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2157 (f073fee) into master (1cfc25c) will increase coverage by 25.55%.
The diff coverage is 60.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2157       +/-   ##
===========================================
+ Coverage   58.80%   84.35%   +25.55%     
===========================================
  Files         101      101               
  Lines        8098     8124       +26     
===========================================
+ Hits         4762     6853     +2091     
+ Misses       3336     1271     -2065     
Flag Coverage Δ
integrationtests 74.34% <60.71%> (?)
unittests 58.80% <60.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/online_stores/sqlite.py 88.23% <60.71%> (-6.39%) ⬇️
sdk/python/feast/data_source.py 61.29% <0.00%> (+0.40%) ⬆️
sdk/python/feast/online_response.py 87.71% <0.00%> (+1.75%) ⬆️
sdk/python/feast/feature.py 90.24% <0.00%> (+4.87%) ⬆️
sdk/python/feast/errors.py 71.11% <0.00%> (+5.18%) ⬆️
sdk/python/feast/infra/provider.py 90.65% <0.00%> (+5.60%) ⬆️
sdk/python/feast/infra/offline_stores/file.py 96.80% <0.00%> (+8.00%) ⬆️
sdk/python/feast/infra/passthrough_provider.py 100.00% <0.00%> (+10.93%) ⬆️
sdk/python/feast/repo_config.py 87.00% <0.00%> (+11.86%) ⬆️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cfc25c...f073fee. Read the comment docs.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex
Copy link
Collaborator

pyalex commented Dec 17, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit c5caeeb into feast-dev:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants