Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release workflow to use the new GCP action #2132

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Dec 10, 2021

What this PR does / why we need it:
There's an outdated action that fails on running the publish helm charts. Switching the release workflow to be consistent with our other workflows, which uses the new action.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@adchia adchia requested a review from a team as a code owner December 10, 2021 01:43
@adchia adchia requested review from achals and removed request for a team December 10, 2021 01:43
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adchia adchia merged commit 1c5330b into feast-dev:master Dec 10, 2021
adchia added a commit that referenced this pull request Dec 11, 2021
@adchia adchia deleted the fixReleaseHelm branch March 4, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants