Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating lambda docker image to feature-server-python-aws #2130

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Updating lambda docker image to feature-server-python-aws #2130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/master_only.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
component: [ feature-server-aws, feature-server-java, feature-transformation-server ]
component: [ feature-server-python-aws, feature-server-java, feature-transformation-server ]
env:
MAVEN_CACHE: gs://feast-templocation-kf-feast/.m2.2020-08-19.tar
REGISTRY: gcr.io/kf-feast
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
needs: get-version
strategy:
matrix:
component: [feature-server-aws, feature-server-java, feature-transformation-server]
component: [feature-server-python-aws, feature-server-java, feature-transformation-server]
env:
MAVEN_CACHE: gs://feast-templocation-kf-feast/.m2.2020-08-19.tar
REGISTRY: feastdev
Expand Down
10 changes: 5 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ lint-go:

# Docker

build-docker: build-ci-docker build-feature-server-aws-docker build-feature-transformation-server-docker build-feature-server-java-docker
build-docker: build-ci-docker build-feature-server-python-aws-docker build-feature-transformation-server-docker build-feature-server-java-docker

push-ci-docker:
docker push $(REGISTRY)/feast-ci:$(VERSION)
Expand All @@ -148,14 +148,14 @@ build-ci-docker:

# Note, we use underscores instead of periods in the version name since ECR doesn't support periods. We automatically
# pull from Docker Hub and push to ECR.
push-feature-server-aws-docker:
push-feature-server-python-aws-docker:
ECR_VERSION=$(shell echo "$(VERSION)" | sed 's/[.]/_/g'); \
docker push $(REGISTRY)/feature-server-aws:$$ECR_VERSION
docker push $(REGISTRY)/feature-server-python-aws:$$ECR_VERSION

build-feature-server-aws-docker:
build-feature-server-python-aws-docker:
ECR_VERSION=$(shell echo "$(VERSION)" | sed 's/[.]/_/g'); \
docker build --build-arg VERSION=$$ECR_VERSION \
-t $(REGISTRY)/feature-server-aws:$$ECR_VERSION \
-t $(REGISTRY)/feature-server-python-aws:$$ECR_VERSION \
-f sdk/python/feast/infra/feature_servers/aws_lambda/Dockerfile .

push-feature-transformation-server-docker:
Expand Down
2 changes: 1 addition & 1 deletion docs/reference/alpha-aws-lambda-feature-server.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ After `feature_store.yaml` has been modified as described in the previous sectio

```bash
$ feast apply
10/07/2021 03:57:26 PM INFO:Pulling remote image feastdev/feature-server-aws:aws:
10/07/2021 03:57:26 PM INFO:Pulling remote image feastdev/feature-server-python-aws:aws:
10/07/2021 03:57:28 PM INFO:Creating remote ECR repository feast-python-server-key_shark-0_13_1_dev23_gb3c08320:
10/07/2021 03:57:29 PM INFO:Pushing local image to remote 402087665549.dkr.ecr.us-west-2.amazonaws.com/feast-python-server-key_shark-0_13_1_dev23_gb3c08320:0_13_1_dev23_gb3c08320:
10/07/2021 03:58:44 PM INFO:Deploying feature server...
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# Maximum interval(secs) to wait between retries for retry function
MAX_WAIT_INTERVAL: str = "60"

AWS_LAMBDA_FEATURE_SERVER_IMAGE = "feastdev/feature-server-aws"
AWS_LAMBDA_FEATURE_SERVER_IMAGE = "feastdev/feature-server-python-aws"
AWS_LAMBDA_FEATURE_SERVER_REPOSITORY = "feast-python-server"

# feature_store.yaml environment variable name for remote feature server
Expand Down