-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove argument feature_refs
#2115
Conversation
This argument was scheduled for removal in 0.14 according the deprecation warning. Signed-off-by: Judah Rand <[email protected]>
Hi @judahrand. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #2115 +/- ##
===========================================
+ Coverage 57.99% 83.54% +25.54%
===========================================
Files 100 100
Lines 8088 8084 -4
===========================================
+ Hits 4691 6754 +2063
+ Misses 3397 1330 -2067
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
AWS API failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, judahrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This argument was scheduled for removal in 0.14 according the deprecation warning. Signed-off-by: Judah Rand <[email protected]>
What this PR does / why we need it:
This argument was scheduled for removal in 0.14 according the
deprecation warning.
Signed-off-by: Judah Rand [email protected]
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: