Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requested_features is passed to online_read from passthrough_provider #2107

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

aurobindoc
Copy link
Contributor

What this PR does / why we need it:
OnlineStore.online_read() has a parameter requested_features. Similarly, PassthroughProvider.online_read() also has a parameter requested_features.
PassthroughProvider.online_read() calls OnlineStore.online_read() but doesn't pass on the requested_features variable.
In this PR, the requested_features variable is passed on to OnlineStore.online_read()

Which issue(s) this PR fixes:
Fixes #2106

Does this PR introduce a user-facing change?:
None

requested_features is passed to online_read from passthrough_provider

@aurobindoc aurobindoc requested a review from a team as a code owner December 5, 2021 17:07
@aurobindoc aurobindoc requested review from tsotnet and removed request for a team December 5, 2021 17:07
@feast-ci-bot
Copy link
Collaborator

Hi @aurobindoc. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aurobindoc aurobindoc force-pushed the passthrough-provider-fix branch from e8739db to b5202df Compare December 5, 2021 17:17
@achals
Copy link
Member

achals commented Dec 5, 2021

/ok-to-test

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2021

Codecov Report

Merging #2107 (b5202df) into master (2d3cea1) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2107      +/-   ##
==========================================
- Coverage   83.53%   83.51%   -0.02%     
==========================================
  Files         100      100              
  Lines        8088     8088              
==========================================
- Hits         6756     6755       -1     
- Misses       1332     1333       +1     
Flag Coverage Δ
integrationtests 73.94% <100.00%> (-0.02%) ⬇️
unittests 57.99% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/passthrough_provider.py 100.00% <100.00%> (ø)
sdk/python/feast/infra/utils/aws_utils.py 84.05% <0.00%> (-1.45%) ⬇️
.../integration/online_store/test_universal_online.py 98.13% <0.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3cea1...b5202df. Read the comment docs.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aurobindoc, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 5d9e5f7 into feast-dev:master Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requested_features are not passed to online_read() from passthrough_provider
5 participants