Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated feature view documentation to include blurb about feature inferencing #2096

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

mavysavydav
Copy link
Collaborator

Signed-off-by: David Y Liu [email protected]

Updated feature view documentation to include blurb about feature inferencing

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #2096 (9f9ba81) into master (54d0f3a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2096   +/-   ##
=======================================
  Coverage   83.44%   83.44%           
=======================================
  Files         100      100           
  Lines        8077     8077           
=======================================
  Hits         6740     6740           
  Misses       1337     1337           
Flag Coverage Δ
integrationtests 73.87% <ø> (ø)
unittests 58.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54d0f3a...9f9ba81. Read the comment docs.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, just two small nits

docs/getting-started/concepts/feature-view.md Outdated Show resolved Hide resolved
docs/getting-started/concepts/feature-view.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, mavysavydav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [felixwang9817,mavysavydav]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 39b6e72 into feast-dev:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants