-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated feature view documentation to include blurb about feature inferencing #2096
Updated feature view documentation to include blurb about feature inferencing #2096
Conversation
Signed-off-by: David Y Liu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2096 +/- ##
=======================================
Coverage 83.44% 83.44%
=======================================
Files 100 100
Lines 8077 8077
=======================================
Hits 6740 6740
Misses 1337 1337
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall, just two small nits
Signed-off-by: David Y Liu <[email protected]>
282de02
to
9f9ba81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, mavysavydav The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: David Y Liu [email protected]