Fix integration test that is unstable due to incorrect materialization boundaries #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyalex
requested review from
achals,
adchia,
felixwang9817,
tsotnet,
woop and
a team
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2095 +/- ##
==========================================
+ Coverage 83.53% 83.71% +0.17%
==========================================
Files 100 100
Lines 8079 8263 +184
==========================================
+ Hits 6749 6917 +168
- Misses 1330 1346 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pyalex
changed the title
pyalex
changed the title
pyalex
changed the title
Signed-off-by: pyalex <[email protected]>
pyalex
changed the title
Signed-off-by: pyalex <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: pyalex [email protected]
What this PR does / why we need it:
test_universal_e2e::test_e2e_consistency is flaky since test records' timestamps and materialization boundaries (start and end times) are generated independently. So materialization is inconsistent, most of the time it writes 3 rows, but in some moments it could materialize the whole test dataframe (5 rows) in one go, which is not expected behavior.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: