Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odfv logic #2088

Merged
merged 3 commits into from
Dec 1, 2021
Merged

Odfv logic #2088

merged 3 commits into from
Dec 1, 2021

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it: This PR refactors some of the ODFV logic in get_online_features.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2021

Codecov Report

Merging #2088 (5584f2d) into master (54d0f3a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2088   +/-   ##
=======================================
  Coverage   83.44%   83.44%           
=======================================
  Files         100      100           
  Lines        8077     8077           
=======================================
  Hits         6740     6740           
  Misses       1337     1337           
Flag Coverage Δ
integrationtests 73.87% <100.00%> (ø)
unittests 58.07% <40.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_store.py 90.22% <100.00%> (ø)
.../integration/online_store/test_universal_online.py 97.67% <0.00%> (-0.47%) ⬇️
sdk/python/feast/infra/utils/aws_utils.py 85.50% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54d0f3a...5584f2d. Read the comment docs.

adchia
adchia previously requested changes Nov 25, 2021
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
@adchia
Copy link
Collaborator

adchia commented Nov 25, 2021

Also, I think this fixes a bug too right? Mind tagging that issue?

Signed-off-by: Felix Wang <[email protected]>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex pyalex dismissed adchia’s stale review December 1, 2021 13:47

blocking merge

@feast-ci-bot feast-ci-bot merged commit cbe5a52 into feast-dev:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants