-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix create_dataset #208
fix create_dataset #208
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: budi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/test all |
/hold cancel |
- remove Clock - update public dataset test
/retest |
/lgtm |
@budi: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix create_dataset to create table insde feast's dataset on BQ rather than creating an actual dataset in BQ (fix #201). Also change table_url from core and sdk to use
full_table_id
.