Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix create_dataset #208

Merged
merged 14 commits into from
Jun 12, 2019
Merged

fix create_dataset #208

merged 14 commits into from
Jun 12, 2019

Conversation

budi
Copy link
Contributor

@budi budi commented May 30, 2019

Fix create_dataset to create table insde feast's dataset on BQ rather than creating an actual dataset in BQ (fix #201). Also change table_url from core and sdk to use full_table_id.

@budi budi requested review from pradithya and davidheryanto May 30, 2019 05:32
@budi budi self-assigned this May 30, 2019
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: budi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidheryanto
Copy link
Collaborator

/hold
Until #209 is merged so we can unit test the python SDK too

@davidheryanto
Copy link
Collaborator

/test all

@davidheryanto
Copy link
Collaborator

/hold cancel

@davidheryanto
Copy link
Collaborator

/retest

@davidheryanto
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit 3a29339 into feast-dev:master Jun 12, 2019
@feast-ci-bot
Copy link
Collaborator

@budi: Updated the config configmap in namespace default using the following files:

  • key config.yaml using file .prow/config.yaml

In response to this:

Fix create_dataset to create table insde feast's dataset on BQ rather than creating an actual dataset in BQ (fix #201). Also change table_url from core and sdk to use full_table_id.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python SDK create_dataset is actually creating dataset in BQ
3 participants