Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --host as an option for feast serve #2078

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

nossrannug
Copy link
Contributor

@nossrannug nossrannug commented Nov 20, 2021

Signed-off-by: Gunnar Sv Sigurbjörnsson [email protected]

What this PR does / why we need it:
Today the value is hardcoded to 127.0.0.1. This will enable users to
specify the host that they want to use for feast serve.

Does this PR introduce a user-facing change?:

NONE

Today the value is hardcoded to 127.0.0.1. This will enable uses to
specify the host that they want to use for feast serve.

Signed-off-by: Gunnar Sv Sigurbjörnsson <[email protected]>
@feast-ci-bot
Copy link
Collaborator

Hi @nossrannug. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2021

Codecov Report

Merging #2078 (1785865) into master (b5d8a53) will increase coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2078      +/-   ##
==========================================
+ Coverage   83.32%   83.33%   +0.01%     
==========================================
  Files         100      100              
  Lines        8084     8085       +1     
==========================================
+ Hits         6736     6738       +2     
+ Misses       1348     1347       -1     
Flag Coverage Δ
integrationtests 73.77% <57.14%> (+0.01%) ⬆️
unittests 58.19% <57.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_server.py 29.72% <50.00%> (ø)
sdk/python/feast/feature_store.py 90.22% <50.00%> (ø)
sdk/python/feast/cli.py 38.41% <66.66%> (+0.19%) ⬆️
sdk/python/feast/infra/utils/aws_utils.py 85.50% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d8a53...1785865. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, nossrannug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 352dd6c into feast-dev:master Nov 24, 2021
@nossrannug nossrannug deleted the allow-host-in-feast-serve branch November 24, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants