Fix feature server docker image tag generation in pr integration tests

[tsotnet]

Signed-off-by: Tsotne Tabidze [email protected]

What this PR does / why we need it: Sometimes is can happen that build-docker-image and integration-test-python workflows run on different git commit hashes. This is because the HEAD commit hash is a merge commit of master and current PR HEAD. If the master gets updated between these 2 workflows, the HEAD commit hash changes, causing integration tests to try to use a wrong feature server docker image tag.

Instead, we'll be setting the commit hash as a workflow output in build-docker-image, then pass it to integration-test-python as an environment variable and use that in integration tests. This will guarantee that the same tag is being used.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

[codecov-commenter]

Codecov Report

Merging #2077 (75bf9f8) into master (3917d5a) will decrease coverage by 25.12%.
The diff coverage is 25.00%.

@@             Coverage Diff             @@
##           master    #2077       +/-   ##
===========================================
- Coverage   83.31%   58.18%   -25.13%     
===========================================
  Files         100      100               
  Lines        8084     8084               
===========================================
- Hits         6735     4704     -2031     
- Misses       1349     3380     +2031     

Flag	Coverage Δ
integrationtests	?
unittests	58.18% <25.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/infra/aws.py	24.15% <0.00%> (-48.45%)	⬇️
sdk/python/feast/constants.py	100.00% <100.00%> (ø)
.../integration/online_store/test_online_retrieval.py	17.39% <0.00%> (-82.61%)	⬇️
.../integration/online_store/test_universal_online.py	15.34% <0.00%> (-82.33%)	⬇️
...fline_store/test_universal_historical_retrieval.py	19.29% <0.00%> (-80.12%)	⬇️
sdk/python/tests/utils/online_read_write_test.py	20.68% <0.00%> (-79.32%)	⬇️
...gration/registration/test_feature_service_apply.py	31.25% <0.00%> (-68.75%)	⬇️
sdk/python/feast/infra/online_stores/redis.py	26.97% <0.00%> (-67.11%)	⬇️
sdk/python/tests/data/data_creator.py	34.78% <0.00%> (-65.22%)	⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py	35.00% <0.00%> (-65.00%)	⬇️
... and 51 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3917d5a...75bf9f8. Read the comment docs.

[adchia]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, tsotnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adchia,tsotnet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[woop]

Shouldn't DOCKER_IMAGE_TAG_ENV_NAME be something "feature server" specific?

[tsotnet]

Why would we use different tags for different servers? Also, we could always rename this if the necessity arises. It won't break anything.