Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytests and make TS conversion conditional #205

Merged
merged 14 commits into from
May 28, 2019

Conversation

zhilingc
Copy link
Collaborator

Addressing issues #204 and #195.

Changes made for #204:

  • Advanced pandas required version to >=0.24.0 and added fastavro to test-requirements.yaml
  • Removed test tests/sdk/utils/test_bq_utils.py::test_query_to_dataframe because it interfaces with BQ and is therefore not a unit test.
  • Changed the python sdk to use pandas nullable int types instead of numpy int types
  • BQ get table util now does not include granularity in the table name
  • Changed importer expected type from file to file.csv, removed format from options

Changes made for #195:

  • Added conditional checking if the timestamp column is declared, if not, will not run timestamp conversion
  • Added test for that case

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhilingc
Copy link
Collaborator Author

/retest

@davidheryanto
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit 7548e61 into feast-dev:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants