Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported java parts #2029

Merged
merged 3 commits into from
Nov 12, 2021
Merged

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Nov 12, 2021

Signed-off-by: pyalex [email protected]

What this PR does / why we need it:

This PR refactors java code in accordance with Feast roadmap:

  • Java core service is removed (including authentication and authorization) since its functionality implemented in Python SDK
  • Serving service now depends only on Registry (produced by Python SDK) as Specifications provider

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: pyalex <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #2029 (92973f6) into master (63680ba) will decrease coverage by 22.88%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2029       +/-   ##
===========================================
- Coverage   83.23%   60.34%   -22.89%     
===========================================
  Files         103      103               
  Lines        8421     8421               
===========================================
- Hits         7009     5082     -1927     
- Misses       1412     3339     +1927     
Flag Coverage Δ
integrationtests ?
unittests 60.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_universal_online.py 14.06% <0.00%> (-84.90%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
...fline_store/test_universal_historical_retrieval.py 19.29% <0.00%> (-80.12%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 20.68% <0.00%> (-79.32%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 26.97% <0.00%> (-67.11%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 35.00% <0.00%> (-65.00%) ⬇️
...s/integration/registration/test_universal_types.py 36.73% <0.00%> (-63.27%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 32.28% <0.00%> (-61.42%) ⬇️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63680ba...92973f6. Read the comment docs.

Signed-off-by: pyalex <[email protected]>
Signed-off-by: pyalex <[email protected]>
@@ -1,154 +0,0 @@
# replicaCount -- Number of pods that will be created
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving a comment here but letting this merge to fix test. We might want to consider having charts, etc within the java subdirectory since there is an analagous sdk/python/feast/infra directory. Could see it going either way though

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

<artifactId>feast-common</artifactId>
<version>${project.version}</version>
</dependency>
<!-- <dependency>-->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this can just be removed? but letting merge since it also fixes tests

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit fbc1d61 into feast-dev:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants