Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct cleanup after usage e2e tests #2015

Merged
merged 3 commits into from
Nov 10, 2021

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Nov 9, 2021

Signed-off-by: pyalex [email protected]

What this PR does / why we need it:

This PR fixes flaky e2e tests for usage module.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021

Codecov Report

Merging #2015 (7dabb85) into master (3ee88f4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2015   +/-   ##
=======================================
  Coverage   83.21%   83.22%           
=======================================
  Files         103      103           
  Lines        8417     8421    +4     
=======================================
+ Hits         7004     7008    +4     
  Misses       1413     1413           
Flag Coverage Δ
integrationtests 74.38% <100.00%> (+0.01%) ⬆️
unittests 60.34% <57.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/integration/e2e/test_usage_e2e.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ee88f4...7dabb85. Read the comment docs.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felixwang9817
Copy link
Collaborator

/kind bug

@feast-ci-bot feast-ci-bot removed the lgtm label Nov 10, 2021
@felixwang9817
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit 06b1f37 into feast-dev:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants