Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate update infra #1990

Merged

Conversation

felixwang9817
Copy link
Collaborator

@felixwang9817 felixwang9817 commented Nov 1, 2021

What this PR does / why we need it: This PR removes the duplicate update_infra call in feast apply. It also cleans up apply_total, by ensuring that entities and ODFVs are also being deleted.

Which issue(s) this PR fixes:

Fixes #1795

Does this PR introduce a user-facing change?:

feast apply only calls update_infra once

@felixwang9817
Copy link
Collaborator Author

/kind bug

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #1990 (a9d57f9) into master (3e42fb3) will decrease coverage by 23.12%.
The diff coverage is 58.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1990       +/-   ##
===========================================
- Coverage   82.08%   58.95%   -23.13%     
===========================================
  Files         100      100               
  Lines        7992     8072       +80     
===========================================
- Hits         6560     4759     -1801     
- Misses       1432     3313     +1881     
Flag Coverage Δ
integrationtests ?
unittests 58.95% <58.33%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/repo_operations.py 42.80% <0.00%> (-1.03%) ⬇️
sdk/python/feast/registry.py 67.48% <90.00%> (-12.96%) ⬇️
sdk/python/feast/feature_store.py 72.58% <100.00%> (-18.74%) ⬇️
...on/tests/integration/registration/test_registry.py 69.91% <100.00%> (-30.09%) ⬇️
.../integration/online_store/test_universal_online.py 13.90% <0.00%> (-85.43%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
...fline_store/test_universal_historical_retrieval.py 19.41% <0.00%> (-80.00%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 20.68% <0.00%> (-79.32%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 25.17% <0.00%> (-67.69%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e42fb3...a9d57f9. Read the comment docs.

sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
@feast-ci-bot feast-ci-bot added size/L and removed size/M labels Nov 3, 2021
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

) != len(
objects
):
raise ValueError("Unknown object type provided as part of apply() call")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a nicer error message here if we could point to which object was the unknown one.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit b39c2a8 into feast-dev:master Nov 4, 2021
@felixwang9817 felixwang9817 deleted the fix_duplicate_update_infra branch November 4, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate update_infra calls in feast apply
4 participants