-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate update infra #1990
Fix duplicate update infra #1990
Conversation
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
/kind bug |
Codecov Report
@@ Coverage Diff @@
## master #1990 +/- ##
===========================================
- Coverage 82.08% 58.95% -23.13%
===========================================
Files 100 100
Lines 7992 8072 +80
===========================================
- Hits 6560 4759 -1801
- Misses 1432 3313 +1881
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Felix Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
) != len( | ||
objects | ||
): | ||
raise ValueError("Unknown object type provided as part of apply() call") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be a nicer error message here if we could point to which object was the unknown one.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: This PR removes the duplicate
update_infra
call infeast apply
. It also cleans upapply_total
, by ensuring that entities and ODFVs are also being deleted.Which issue(s) this PR fixes:
Fixes #1795
Does this PR introduce a user-facing change?: