-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve aws lambda deployment (logging, idempotency, etc) #1985
Improve aws lambda deployment (logging, idempotency, etc) #1985
Conversation
Signed-off-by: Tsotne Tabidze <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1985 +/- ##
==========================================
+ Coverage 82.07% 82.15% +0.08%
==========================================
Files 100 101 +1
Lines 7987 8074 +87
==========================================
+ Hits 6555 6633 +78
- Misses 1432 1441 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Tsotne Tabidze <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great overall, just one quick comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will leave @felixwang9817 to give the lgtm, but the code lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817, tsotnet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: Tsotne Tabidze [email protected]
What this PR does / why we need it: This PR fixes or improves a couple of things
--log-level=debug
, for examplefeast --log-level=debug apply
. Also, looks like log-level flag was not working correctly, so I also fixed that.feast apply
, users won't need to have docker daemon running (which was required on each apply before).Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: