Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate upload entity #1981

Merged

Conversation

achals
Copy link
Member

@achals achals commented Oct 27, 2021

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

none

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2021

Codecov Report

Merging #1981 (2596bd3) into master (252ca47) will decrease coverage by 22.77%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1981       +/-   ##
===========================================
- Coverage   82.07%   59.30%   -22.78%     
===========================================
  Files         100      100               
  Lines        7991     7991               
===========================================
- Hits         6559     4739     -1820     
- Misses       1432     3252     +1820     
Flag Coverage Δ
integrationtests ?
unittests 59.30% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/bigquery.py 31.51% <0.00%> (-48.49%) ⬇️
.../integration/online_store/test_universal_online.py 15.33% <0.00%> (-84.00%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 18.18% <0.00%> (-81.82%) ⬇️
...fline_store/test_universal_historical_retrieval.py 19.41% <0.00%> (-80.00%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 29.36% <0.00%> (-63.50%) ⬇️
...s/integration/registration/test_universal_types.py 36.73% <0.00%> (-63.27%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 30.32% <0.00%> (-63.12%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 252ca47...2596bd3. Read the comment docs.

Copy link
Collaborator

@MattDelac MattDelac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was not the root cause of my issue but this fix remain valid for historical retrieval that will use on_demande_feature_views

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, MattDelac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MattDelac
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit 9932600 into feast-dev:master Oct 27, 2021
felixwang9817 pushed a commit that referenced this pull request Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants