Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve package conflict in [gcp] and [ci] #1955

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Solve package conflict in [gcp] and [ci] #1955

merged 1 commit into from
Oct 20, 2021

Conversation

ysk24ok
Copy link
Contributor

@ysk24ok ysk24ok commented Oct 18, 2021

What this PR does / why we need it:

This PR fixes Installing feast[gcp] and feast[ci] fails due to package conflict.
Both extra packages try to install google-cloud-core==1.4.* but the latest version of google-cloud-storage (the latest version is 1.42.3 for now) tries to install google-cloud-core<3.0dev,>=1.6.0 .

Steps to reproduce are as follows:

$ cat Pipfile
[[source]]
url = "https://pypi.org/simple"
verify_ssl = true
name = "pypi"

[packages]
feast = {extras = ["gcp"], version = "*"}

[dev-packages]

[requires]
python_version = "3.9"
$ pipenv install 
...
ERROR: Could not find a version that matches google-cloud-core<3.0.0dev,<3.0dev,==1.4.*,>=1.4.0,>=1.4.1,>=1.6.0 (from feast[gcp]==0.14.0->-r /var/folders/rv/h226tqmj72xbpjyjjf2hr5xc0000gp/T/pipenv3doi2g2zrequirements/pipenv-u9o2xijh-constraints.txt (line 4))
Tried: 0.20.0, 0.20.0, 0.21.0, 0.21.0, 0.22.0, 0.22.0, 0.22.1, 0.22.1, 0.23.0, 0.23.0, 0.23.1, 0.23.1, 0.24.0, 0.24.0, 0.24.1, 0.24.1, 0.25.0, 0.25.0, 0.26.0, 0.26.0, 0.27.0, 0.27.0, 0.27.1, 0.27.1, 0.28.0, 0.28.0, 0.28.1, 0.28.1, 0.29.0, 0.29.0, 0.29.1, 0.29.1, 1.0.0, 1.0.0, 1.0.1, 1.0.1, 1.0.2, 1.0.2, 1.0.3, 1.0.3, 1.1.0, 1.1.0, 1.2.0, 1.2.0, 1.3.0, 1.3.0, 1.4.0, 1.4.0, 1.4.1, 1.4.1, 1.4.2, 1.4.2, 1.4.3, 1.4.3, 1.4.4, 1.4.4, 1.5.0, 1.5.0, 1.6.0, 1.6.0, 1.7.0, 1.7.0, 1.7.1, 1.7.1, 1.7.2, 1.7.2, 2.0.0, 2.0.0, 2.1.0, 2.1.0
Tried pre-versions: 1.4.2rc1, 1.4.2rc1, 1.4.2rc2, 1.4.2rc2, 2.0.0b1, 2.0.0b1
There are incompatible versions in the resolved dependencies:
  google-cloud-core<3.0.0dev,>=1.4.0 (from google-cloud-datastore==2.2.0->feast[gcp]==0.14.0->-r /var/folders/rv/h226tqmj72xbpjyjjf2hr5xc0000gp/T/pipenv3doi2g2zrequirements/pipenv-u9o2xijh-constraints.txt (line 4))
  google-cloud-core<3.0.0dev,>=1.4.1 (from google-cloud-bigquery==2.28.1->feast[gcp]==0.14.0->-r /var/folders/rv/h226tqmj72xbpjyjjf2hr5xc0000gp/T/pipenv3doi2g2zrequirements/pipenv-u9o2xijh-constraints.txt (line 4))
  google-cloud-core<3.0dev,>=1.6.0 (from google-cloud-storage==1.42.3->feast[gcp]==0.14.0->-r /var/folders/rv/h226tqmj72xbpjyjjf2hr5xc0000gp/T/pipenv3doi2g2zrequirements/pipenv-u9o2xijh-constraints.txt (line 4))
  google-cloud-core==1.4.* (from feast[gcp]==0.14.0->-r /var/folders/rv/h226tqmj72xbpjyjjf2hr5xc0000gp/T/pipenv3doi2g2zrequirements/pipenv-u9o2xijh-constraints.txt (line 4))

google-cloud-storage==1.40.0 requires google-cloud-core >= 1.4.1, < 2.0dev (see here) and google-cloud-storage>=1.41.0 requires google-cloud-core >= 1.6.0 (see here). So I decided to constrain the version under 1.41.

Another way to fix this problem is to install google-cloud-core >= 1.4.* , but I didn't choose this because I'm not sure it's OK...

Which issue(s) this PR fixes:

Fixes #1912

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

Hi @ysk24ok. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #1955 (5efd900) into master (2541c91) will decrease coverage by 22.41%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1955       +/-   ##
===========================================
- Coverage   81.93%   59.51%   -22.42%     
===========================================
  Files          99       99               
  Lines        7922     7922               
===========================================
- Hits         6491     4715     -1776     
- Misses       1431     3207     +1776     
Flag Coverage Δ
integrationtests ?
unittests 59.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_universal_online.py 14.17% <0.00%> (-85.08%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 18.18% <0.00%> (-81.82%) ⬇️
...fline_store/test_universal_historical_retrieval.py 19.41% <0.00%> (-80.00%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
...s/integration/registration/test_universal_types.py 36.73% <0.00%> (-63.27%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 30.35% <0.00%> (-62.50%) ⬇️
sdk/python/feast/infra/online_stores/dynamodb.py 30.37% <0.00%> (-60.76%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 30.32% <0.00%> (-60.66%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2541c91...5efd900. Read the comment docs.

@felixwang9817
Copy link
Collaborator

/kind bug

@felixwang9817
Copy link
Collaborator

/ok-to-test

@felixwang9817
Copy link
Collaborator

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, ysk24ok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felixwang9817
Copy link
Collaborator

thanks for the fix @ysk24ok!

@feast-ci-bot feast-ci-bot merged commit ea00d50 into feast-dev:master Oct 20, 2021
@ysk24ok ysk24ok deleted the patch-2 branch October 20, 2021 21:54
@ysk24ok
Copy link
Contributor Author

ysk24ok commented Oct 20, 2021

@felixwang9817 Thank you for merging this.
v0.14.0 has been released, but this problem remains in the version because this PR is not included.
How about releasing a new patch version (i.e. v0.14.1)? Users might be confused with the installation failure.

@felixwang9817
Copy link
Collaborator

@ysk24ok I agree - we're planning on releasing a patch version quite soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solve feast conflict dependencies for [gcp]
4 participants