-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve package conflict in [gcp] and [ci] #1955
Conversation
Hi @ysk24ok. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1955 +/- ##
===========================================
- Coverage 81.93% 59.51% -22.42%
===========================================
Files 99 99
Lines 7922 7922
===========================================
- Hits 6491 4715 -1776
- Misses 1431 3207 +1776
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Yusuke Nishioka <[email protected]>
/kind bug |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, ysk24ok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks for the fix @ysk24ok! |
@felixwang9817 Thank you for merging this. |
@ysk24ok I agree - we're planning on releasing a patch version quite soon! |
What this PR does / why we need it:
This PR fixes Installing
feast[gcp]
andfeast[ci]
fails due to package conflict.Both extra packages try to install
google-cloud-core==1.4.*
but the latest version ofgoogle-cloud-storage
(the latest version is1.42.3
for now) tries to installgoogle-cloud-core<3.0dev,>=1.6.0
.Steps to reproduce are as follows:
google-cloud-storage==1.40.0
requiresgoogle-cloud-core >= 1.4.1, < 2.0dev
(see here) andgoogle-cloud-storage>=1.41.0
requiresgoogle-cloud-core >= 1.6.0
(see here). So I decided to constrain the version under1.41
.Another way to fix this problem is to install
google-cloud-core >= 1.4.*
, but I didn't choose this because I'm not sure it's OK...Which issue(s) this PR fixes:
Fixes #1912
Does this PR introduce a user-facing change?: