Fix conditional statements for if OnDemandFVs exist

[codyjlin]

Signed-off-by: Cody Lin [email protected]

What this PR does / why we need it:
There's an inconsistency for checking whether there are self.on_demand_feature_views - if this value is an empty list [] as returned by on_demand_feature_view.get_requested_odfvs (like here), then the old conditional statements are wrong.

Which issue(s) this PR fixes:

Small bugfix, no issue

Does this PR introduce a user-facing change?:

NONE

[feast-ci-bot]

Hi @codyjlin. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codyjlin]

/kind bug

[codecov-commenter]

Codecov Report

Merging #1937 (4a931ec) into master (156d004) will decrease coverage by 22.88%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master    #1937       +/-   ##
===========================================
- Coverage   82.27%   59.39%   -22.89%     
===========================================
  Files          96       96               
  Lines        7669     7669               
===========================================
- Hits         6310     4555     -1755     
- Misses       1359     3114     +1755     

Flag	Coverage Δ
integrationtests	?
unittests	59.39% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/infra/offline_stores/bigquery.py	30.38% <0.00%> (-49.73%)	⬇️
sdk/python/feast/infra/offline_stores/redshift.py	36.66% <0.00%> (-48.34%)	⬇️
.../integration/online_store/test_universal_online.py	13.74% <0.00%> (-85.50%)	⬇️
.../integration/online_store/test_online_retrieval.py	17.39% <0.00%> (-82.61%)	⬇️
...fline_store/test_universal_historical_retrieval.py	17.14% <0.00%> (-82.15%)	⬇️
sdk/python/tests/utils/online_read_write_test.py	18.18% <0.00%> (-81.82%)	⬇️
...gration/registration/test_feature_service_apply.py	31.25% <0.00%> (-68.75%)	⬇️
sdk/python/tests/data/data_creator.py	34.78% <0.00%> (-65.22%)	⬇️
...s/integration/registration/test_universal_types.py	35.41% <0.00%> (-64.59%)	⬇️
...istration/test_universal_odfv_feature_inference.py	35.71% <0.00%> (-64.29%)	⬇️
... and 47 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 156d004...4a931ec. Read the comment docs.

[mavysavydav]

/lgtm

[feast-ci-bot]

@mavysavydav: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adchia]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, codyjlin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adchia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment