Fix __getitem__ return value for feature view and on-demand feature view

[mavysavydav]

Signed-off-by: David Y Liu [email protected]

It should be returning the copy that was made.

[feast-ci-bot]

@mavysavydav: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[feast-ci-bot]

Hi @mavysavydav. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mavysavydav]

/kind bug

[codyjlin]

Much needed bug fix, thanks 👍

[codecov-commenter]

Codecov Report

Merging #1936 (0015262) into master (94737f6) will decrease coverage by 22.88%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master    #1936       +/-   ##
===========================================
- Coverage   82.26%   59.38%   -22.89%     
===========================================
  Files          96       96               
  Lines        7669     7669               
===========================================
- Hits         6309     4554     -1755     
- Misses       1360     3115     +1755     

Flag	Coverage Δ
integrationtests	?
unittests	59.38% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/feature_view.py	73.29% <0.00%> (-14.21%)	⬇️
sdk/python/feast/on_demand_feature_view.py	31.38% <0.00%> (-54.75%)	⬇️
.../integration/online_store/test_universal_online.py	13.74% <0.00%> (-85.50%)	⬇️
.../integration/online_store/test_online_retrieval.py	17.39% <0.00%> (-82.61%)	⬇️
...fline_store/test_universal_historical_retrieval.py	17.14% <0.00%> (-82.15%)	⬇️
sdk/python/tests/utils/online_read_write_test.py	18.18% <0.00%> (-81.82%)	⬇️
...gration/registration/test_feature_service_apply.py	31.25% <0.00%> (-68.75%)	⬇️
sdk/python/tests/data/data_creator.py	34.78% <0.00%> (-65.22%)	⬇️
...s/integration/registration/test_universal_types.py	35.41% <0.00%> (-64.59%)	⬇️
...istration/test_universal_odfv_feature_inference.py	35.71% <0.00%> (-64.29%)	⬇️
... and 47 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94737f6...0015262. Read the comment docs.

[achals]

/lgtm

We should probably have caught this in tests, no?

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, codyjlin, mavysavydav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [achals]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment