-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected setup.py BigQuery version that's needed for a contributor's merged PR 1844 #1934
Corrected setup.py BigQuery version that's needed for a contributor's merged PR 1844 #1934
Conversation
Signed-off-by: David Y Liu <[email protected]>
@mavysavydav: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @mavysavydav. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind bug |
Codecov Report
@@ Coverage Diff @@
## master #1934 +/- ##
=======================================
Coverage 82.26% 82.26%
=======================================
Files 96 96
Lines 7669 7669
=======================================
Hits 6309 6309
Misses 1360 1360
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, mavysavydav The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#1934) Signed-off-by: David Y Liu <[email protected]>
Signed-off-by: David Y Liu [email protected]
The following PR by a contributor was merged but it assumes a higher version of google-cloud-bigquery. Passing in job objects to get_job and cancel_job only was supported in 2.14.0.
https://github.com/feast-dev/feast/pull/1844/files
2.14.0 changes reference - https://newreleases.io/project/pypi/google-cloud-bigquery/release/2.14.0