Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected setup.py BigQuery version that's needed for a contributor's merged PR 1844 #1934

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

mavysavydav
Copy link
Collaborator

@mavysavydav mavysavydav commented Oct 13, 2021

Signed-off-by: David Y Liu [email protected]

The following PR by a contributor was merged but it assumes a higher version of google-cloud-bigquery. Passing in job objects to get_job and cancel_job only was supported in 2.14.0.
https://github.com/feast-dev/feast/pull/1844/files
2.14.0 changes reference - https://newreleases.io/project/pypi/google-cloud-bigquery/release/2.14.0

@feast-ci-bot
Copy link
Collaborator

@mavysavydav: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot
Copy link
Collaborator

Hi @mavysavydav. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mavysavydav
Copy link
Collaborator Author

/kind bug

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021

Codecov Report

Merging #1934 (56be1a2) into master (f1df40a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1934   +/-   ##
=======================================
  Coverage   82.26%   82.26%           
=======================================
  Files          96       96           
  Lines        7669     7669           
=======================================
  Hits         6309     6309           
  Misses       1360     1360           
Flag Coverage Δ
integrationtests 74.15% <ø> (ø)
unittests 59.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1df40a...56be1a2. Read the comment docs.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, mavysavydav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 94737f6 into feast-dev:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants