-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create & teardown Lambda & API Gateway resources for serverless feature server #1900
Create & teardown Lambda & API Gateway resources for serverless feature server #1900
Conversation
…re server Signed-off-by: Tsotne Tabidze <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
a503085
to
9d6f45b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1900 +/- ##
==========================================
- Coverage 82.97% 82.27% -0.70%
==========================================
Files 96 96
Lines 7376 7470 +94
==========================================
+ Hits 6120 6146 +26
- Misses 1256 1324 +68
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some nits, but the PR looks mostly good. Are you planning on adding tests in this pass or is that going to be punted to a subsequent PR?
Signed-off-by: Felix Wang <[email protected]>
@achals yes I plan on doing tests in a later PR (since tests are not necessary for a the serverless MVP). |
Cool. I had one more nit but looks good otherwise. |
Signed-off-by: Felix Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, tsotnet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Create & teardown Lambda & API Gateway resources for serverless feature server
Signed-off-by: Tsotne Tabidze [email protected]
What this PR does / why we need it: Here we implement update_infra and teardown_infra methods of AwsProvider, creating and destroying lambda & API gateway resources.
Here's what
feast apply
looks like:And here's what
feast teardown
looks like:Currently
feast endpoint
isn't implemented, so we don't show the HTTP endpoint anywhere, although I checked it from AWS Console and sending some cURL requests worked as expected.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: