Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create & teardown Lambda & API Gateway resources for serverless feature server #1900

Merged

Conversation

tsotnet
Copy link
Collaborator

@tsotnet tsotnet commented Sep 22, 2021

Create & teardown Lambda & API Gateway resources for serverless feature server

Signed-off-by: Tsotne Tabidze [email protected]

What this PR does / why we need it: Here we implement update_infra and teardown_infra methods of AwsProvider, creating and destroying lambda & API gateway resources.

Here's what feast apply looks like:

Deploying feature server...
  Creating AWS Lambda...
  Creating AWS API Gateway...
Registered entity driver_id
Registered feature view driver_hourly_stats
Deploying infrastructure for driver_hourly_stats
Deploying feature server...

And here's what feast teardown looks like:

Tearing down feature server...
  Tearing down AWS Lambda...
  Tearing down AWS API Gateway...

Currently feast endpoint isn't implemented, so we don't show the HTTP endpoint anywhere, although I checked it from AWS Console and sending some cURL requests worked as expected.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@felixwang9817 felixwang9817 force-pushed the tsotne/feature_server_lambda_gateway branch from a503085 to 9d6f45b Compare October 1, 2021 22:39
@felixwang9817 felixwang9817 assigned achals and unassigned felixwang9817 Oct 1, 2021
@felixwang9817 felixwang9817 changed the title Create & Tardown Lambda & API Gateway resources for serverless feature server Create & teardown Lambda & API Gateway resources for serverless feature server Oct 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2021

Codecov Report

Merging #1900 (4123b5c) into master (0155284) will decrease coverage by 0.69%.
The diff coverage is 31.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1900      +/-   ##
==========================================
- Coverage   82.97%   82.27%   -0.70%     
==========================================
  Files          96       96              
  Lines        7376     7470      +94     
==========================================
+ Hits         6120     6146      +26     
- Misses       1256     1324      +68     
Flag Coverage Δ
integrationtests 73.82% <31.81%> (-0.59%) ⬇️
unittests 60.20% <28.18%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/passthrough_provider.py 100.00% <ø> (+4.00%) ⬆️
sdk/python/feast/infra/utils/aws_utils.py 71.01% <22.22%> (-12.03%) ⬇️
sdk/python/feast/infra/aws.py 40.62% <27.14%> (-10.87%) ⬇️
sdk/python/feast/errors.py 70.07% <66.66%> (-0.24%) ⬇️
sdk/python/feast/constants.py 100.00% <100.00%> (ø)
sdk/python/feast/usage.py 66.89% <100.00%> (+0.22%) ⬆️
sdk/python/feast/infra/offline_stores/bigquery.py 80.11% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0155284...4123b5c. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some nits, but the PR looks mostly good. Are you planning on adding tests in this pass or is that going to be punted to a subsequent PR?

sdk/python/feast/constants.py Outdated Show resolved Hide resolved
sdk/python/feast/infra/aws.py Outdated Show resolved Hide resolved
sdk/python/feast/infra/aws.py Outdated Show resolved Hide resolved
sdk/python/feast/infra/aws.py Outdated Show resolved Hide resolved
sdk/python/feast/infra/aws.py Outdated Show resolved Hide resolved
sdk/python/feast/infra/aws.py Show resolved Hide resolved
sdk/python/feast/infra/utils/aws_utils.py Outdated Show resolved Hide resolved
sdk/python/feast/infra/utils/aws_utils.py Outdated Show resolved Hide resolved
Signed-off-by: Felix Wang <[email protected]>
@felixwang9817
Copy link
Collaborator

@achals yes I plan on doing tests in a later PR (since tests are not necessary for a the serverless MVP).

@achals
Copy link
Member

achals commented Oct 3, 2021

@achals yes I plan on doing tests in a later PR (since tests are not necessary for a the serverless MVP).

Cool. I had one more nit but looks good otherwise.

Signed-off-by: Felix Wang <[email protected]>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, tsotnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 41535d0 into feast-dev:master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants