Hide FeatureViewProjections from user interface & have FeatureViews carry FVProjections that carries the modified info of the FeatureView

[mavysavydav]

DEPENDENT ON - #1899

What this PR does / why we need it: #1907

Which issue(s) this PR fixes: #1907

Fixes #1907

Does this PR introduce a user-facing change?:

When users do my_feature_view[[feature_a, ...]], a FeatureView will be returned rather than a FeatureViewProjection. This doesn't really impact anything from a usage perspective and users don't need to make any adjustments.  Everything will work the same as before. 

[feast-ci-bot]

Hi @mavysavydav. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov-commenter]

Codecov Report

Merging #1899 (31cd6a8) into master (5d0f37b) will decrease coverage by 22.82%.
The diff coverage is 39.06%.

@@             Coverage Diff             @@
##           master    #1899       +/-   ##
===========================================
- Coverage   82.95%   60.13%   -22.83%     
===========================================
  Files          96       96               
  Lines        7359     7490      +131     
===========================================
- Hits         6105     4504     -1601     
- Misses       1254     2986     +1732     

Flag	Coverage Δ
integrationtests	?
unittests	60.13% <39.06%> (-0.64%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/cli.py	39.27% <0.00%> (ø)
.../integration/online_store/test_universal_online.py	14.58% <ø> (-85.42%)	⬇️
sdk/python/feast/on_demand_feature_view.py	32.25% <25.00%> (-57.22%)	⬇️
sdk/python/feast/feature_service.py	61.76% <36.36%> (-13.58%)	⬇️
sdk/python/feast/feature_view.py	78.12% <38.46%> (-8.46%)	⬇️
sdk/python/feast/feature_store.py	75.94% <46.15%> (-17.87%)	⬇️
sdk/python/feast/feature_view_projection.py	63.63% <100.00%> (-36.37%)	⬇️
.../integration/online_store/test_online_retrieval.py	17.39% <0.00%> (-82.61%)	⬇️
sdk/python/tests/utils/online_read_write_test.py	18.18% <0.00%> (-81.82%)	⬇️
... and 54 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d0f37b...31cd6a8. Read the comment docs.

[mavysavydav]

/retest

[woop]

What happened to setup.py?

[woop]

I'm curious why you moved this code out of the constructor. Don't feel strongly about it though.

[woop]

Nitpick: These comments assume the user knows exactly what a projection is. I think it's important to define what a projection is.

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, mavysavydav, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [achals,woop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[woop]

/lgtm