-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload benchmark information to S3 after integration test runs #1878
Upload benchmark information to S3 after integration test runs #1878
Conversation
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1878 +/- ##
===========================================
- Coverage 83.81% 62.35% -21.46%
===========================================
Files 96 96
Lines 7316 7316
===========================================
- Hits 6132 4562 -1570
- Misses 1184 2754 +1570
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Achal Shah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Achal Shah [email protected]
What this PR does / why we need it:
Uploading benchmark data to S3 allows us to compare it later in the future using https://pytest-benchmark.readthedocs.io/en/latest/comparing.html
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: