Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding telemetry for on demand feature views and making existing usage calls async #1873

Merged
merged 6 commits into from
Sep 17, 2021

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Sep 16, 2021

What this PR does / why we need it:
Adding telemetry for on demand feature views and making existing usage calls async

Tested this locally to ensure the events are logged correctly and that the get_online_features logs only trigger once every 10k requests.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

sdk/python/feast/usage.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Show resolved Hide resolved
sdk/python/feast/usage.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2021

Codecov Report

Merging #1873 (14f301d) into master (8a49a65) will increase coverage by 0.47%.
The diff coverage is 64.61%.

❗ Current head 14f301d differs from pull request most recent head fc49dfc. Consider uploading reports for the commit fc49dfc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1873      +/-   ##
==========================================
+ Coverage   83.96%   84.44%   +0.47%     
==========================================
  Files          95       93       -2     
  Lines        7392     7309      -83     
==========================================
- Hits         6207     6172      -35     
+ Misses       1185     1137      -48     
Flag Coverage Δ
integrationtests 84.44% <64.61%> (+9.70%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/usage.py 60.00% <45.23%> (-0.96%) ⬇️
sdk/python/feast/feature_store.py 94.45% <100.00%> (+0.78%) ⬆️
sdk/python/feast/infra/online_stores/datastore.py 92.50% <0.00%> (-0.95%) ⬇️
sdk/python/feast/flags.py
sdk/python/feast/flags_helper.py
sdk/python/feast/errors.py 70.49% <0.00%> (+0.09%) ⬆️
sdk/python/feast/infra/offline_stores/bigquery.py 78.66% <0.00%> (+0.14%) ⬆️
sdk/python/tests/conftest.py 96.36% <0.00%> (+1.05%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a49a65...fc49dfc. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit efeea6c into feast-dev:master Sep 17, 2021
@adchia adchia deleted the odfv_telemetry branch October 27, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants