Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial docker image for aws lambda feature server #1866

Merged
merged 3 commits into from
Sep 15, 2021

Conversation

tsotnet
Copy link
Collaborator

@tsotnet tsotnet commented Sep 15, 2021

Signed-off-by: Tsotne Tabidze [email protected]

What this PR does / why we need it: This PR creates an initial dockerfile for AWS lambda feature server.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Tsotne Tabidze <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021

Codecov Report

Merging #1866 (d31fa8a) into master (bf5dc7d) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1866      +/-   ##
==========================================
+ Coverage   84.92%   84.97%   +0.04%     
==========================================
  Files          92       92              
  Lines        7185     7202      +17     
==========================================
+ Hits         6102     6120      +18     
+ Misses       1083     1082       -1     
Flag Coverage Δ
integrationtests 84.90% <ø> (+0.04%) ⬆️
unittests 62.60% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/online_stores/helpers.py 86.20% <0.00%> (-0.46%) ⬇️
...ts/integration/feature_repos/repo_configuration.py 100.00% <0.00%> (ø)
.../integration/online_store/test_universal_online.py 100.00% <0.00%> (ø)
...fline_store/test_universal_historical_retrieval.py 99.18% <0.00%> (+0.04%) ⬆️
...tegration/feature_repos/universal/feature_views.py 96.66% <0.00%> (+0.23%) ⬆️
sdk/python/feast/infra/provider.py 90.08% <0.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf5dc7d...d31fa8a. Read the comment docs.

Signed-off-by: Tsotne Tabidze <[email protected]>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, tsotnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [felixwang9817,tsotnet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tsotnet tsotnet merged commit af95bf0 into feast-dev:master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants