Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature server configuration for AWS lambda #1865

Merged
merged 6 commits into from
Sep 15, 2021

Conversation

felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang [email protected]

What this PR does / why we need it: This PR adds the option to add a feature server configuration to feature_store.yaml. Right now, only AWS lambda is supported.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

The user can now define a feature server in `feature_store.yaml`.

@felixwang9817
Copy link
Collaborator Author

/kind feature

@feast-ci-bot feast-ci-bot added kind/feature New feature or request and removed needs-kind labels Sep 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021

Codecov Report

Merging #1865 (9fb1d09) into master (bf5dc7d) will decrease coverage by 0.17%.
The diff coverage is 43.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1865      +/-   ##
==========================================
- Coverage   84.92%   84.75%   -0.18%     
==========================================
  Files          92       92              
  Lines        7185     7241      +56     
==========================================
+ Hits         6102     6137      +35     
- Misses       1083     1104      +21     
Flag Coverage Δ
integrationtests 84.68% <43.58%> (-0.18%) ⬇️
unittests 62.47% <38.46%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/repo_config.py 82.38% <36.66%> (-10.64%) ⬇️
sdk/python/feast/errors.py 70.49% <66.66%> (-0.31%) ⬇️
sdk/python/feast/infra/online_stores/helpers.py 86.20% <0.00%> (-0.46%) ⬇️
...ts/integration/feature_repos/repo_configuration.py 100.00% <0.00%> (ø)
.../integration/online_store/test_universal_online.py 100.00% <0.00%> (ø)
...fline_store/test_universal_historical_retrieval.py 99.18% <0.00%> (+0.04%) ⬆️
...tegration/feature_repos/universal/feature_views.py 96.66% <0.00%> (+0.23%) ⬆️
sdk/python/feast/infra/provider.py 90.08% <0.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf5dc7d...9fb1d09. Read the comment docs.

sdk/python/feast/infra/feature_servers/aws_lambda/app.py Outdated Show resolved Hide resolved
sdk/python/feast/infra/feature_servers/aws_lambda/app.py Outdated Show resolved Hide resolved
sdk/python/feast/infra/feature_servers/aws_lambda/app.py Outdated Show resolved Hide resolved
sdk/python/feast/repo_config.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@tsotnet tsotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, tsotnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [felixwang9817,tsotnet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit b3d58f6 into feast-dev:master Sep 15, 2021
@felixwang9817 felixwang9817 deleted the feature_server_config branch September 16, 2021 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants