-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MVP support for on demand transforms for AWS to_s3 and to_redshift #1856
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1856 +/- ##
==========================================
- Coverage 85.08% 84.91% -0.18%
==========================================
Files 91 91
Lines 7095 7111 +16
==========================================
+ Hits 6037 6038 +1
- Misses 1058 1073 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Danny Chiao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add MVP support for on demand transforms for AWS to_s3 and to_redshift
Tested with a local repo that uploaded to s3 + to_redshift and inspected results to see on demand transform properly applied into a new column
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: