Support on demand feature views in feature services #1849
Conversation
Signed-off-by: Achal Shah <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1849 +/- ##
==========================================
+ Coverage 84.84% 84.87% +0.02%
==========================================
Files 91 91
Lines 6924 6961 +37
==========================================
+ Hits 5875 5908 +33
- Misses 1049 1053 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/retest |
|
|
||
| def response_feature_name(feature: str, full_feature_names: bool) -> str: | ||
| if ( | ||
| feature in {"current_balance", "avg_passenger_count", "lifetime_trip_count"} |
There was a problem hiding this comment.
seems like you only ever call this with conv_rate?
There was a problem hiding this comment.
could remove other if blocks if they're not needed
There was a problem hiding this comment.
Yeah I copied over the one from test_universal_online. Removing.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: