-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the types test to run on all compatible environments #1840
Conversation
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1840 +/- ##
==========================================
+ Coverage 84.32% 84.45% +0.12%
==========================================
Files 93 90 -3
Lines 6869 6772 -97
==========================================
- Hits 5792 5719 -73
+ Misses 1077 1053 -24
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Enables the types test to test feature types across compatible offline / online stores (but e.g. not using list features on Redshift since Redshift doesn't support those). This also doesn't fully enable testing materializing list features for BQ because of #1839.
This also fixes some missing teardown functionality, which caused tests to fail because the same "project" across different environments that used the same offline store caused issues (e.g. inability to create a new dataset)
This surfaced a bug where we can't materialize list features in BQ. There's a J
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: